From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote request code Date: Thu, 27 Aug 2009 16:24:58 +0300 Message-ID: <4A96892A.1070905@redhat.com> References: <20090827012000.762063112@localhost.localdomain> <20090827012955.208915957@localhost.localdomain> <4A96409B.3020001@redhat.com> <20090827124526.GA3476@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60801 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbZH0NY6 (ORCPT ); Thu, 27 Aug 2009 09:24:58 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n7RDP09Z005099 for ; Thu, 27 Aug 2009 09:25:00 -0400 In-Reply-To: <20090827124526.GA3476@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 08/27/2009 03:45 PM, Marcelo Tosatti wrote: >> Why not bool guest_mode? Saves two atomics per exit. >> > It must be atomic since GUEST_MODE / VCPU_KICKED bits are manipulated by > multiple CPU's. > bools are atomic. -- error compiling committee.c: too many arguments to function