From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [patch 2/5] KVM: reintroduce guest mode bit and unify remote
 request code
Date: Fri, 28 Aug 2009 10:22:49 +0300
Message-ID: <4A9785C9.5070209@redhat.com>
References: <20090827012000.762063112@localhost.localdomain> <20090827012955.208915957@localhost.localdomain> <4A96409B.3020001@redhat.com> <20090827124526.GA3476@amt.cnet> <4A96892A.1070905@redhat.com> <20090827140730.GA4345@amt.cnet> <4A9781E4.6000405@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm@vger.kernel.org, "Yang, Sheng" <sheng.yang@intel.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32267 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751665AbZH1HWX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 28 Aug 2009 03:22:23 -0400
In-Reply-To: <4A9781E4.6000405@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/28/2009 10:06 AM, Avi Kivity wrote:
>
> Why do we need both, btw?  Set your vcpu->requests bit, if guest_mode 
> is true, clear it and IPI.  So guest_mode=false means, we might be in 
> guest mode but if so we're due for a kick anyway.

No, this introduces a race.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.