From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCHv3] VMX: Enhance invalid guest state emulation Date: Tue, 01 Sep 2009 19:23:26 +0300 Message-ID: <4A9D4A7E.5000800@redhat.com> References: <1251802098-23819-1-git-send-email-m.gamal005@gmail.com> <20090901114806.GA18778@amt.cnet> <52d4a3890909010514n20ceef87i4767e277c550a581@mail.gmail.com> <20090901121804.GA19145@amt.cnet> <52d4a3890909010608h1f406b42j98d403493859d6b6@mail.gmail.com> <20090901132938.GA19864@amt.cnet> <52d4a3890909010632wd1b6d9fxb2b5f5042e151b4f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Mohammed Gamal Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9174 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754460AbZIAQXe (ORCPT ); Tue, 1 Sep 2009 12:23:34 -0400 In-Reply-To: <52d4a3890909010632wd1b6d9fxb2b5f5042e151b4f@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/01/2009 04:32 PM, Mohammed Gamal wrote: >>> I'd appreciate any suggestions you have to alleviate this. >>> >> I fail to see why you need an internal loop if you can use the external >> (__vcpu_run) one. >> > Because it's not just used by VMX. So I don't think it'd be wise to > use it for something that's VMX-specific. > The loop is there anyway. The only question is whether vmx_handle_exit() emulates on instruction or many. Emulating one instruction is slower, but will get interrupt injection more accurate (once we have emulated real mode interrupt injection). -- error compiling committee.c: too many arguments to function