From: Chris Lalancette <clalance@redhat.com>
To: Glauber Costa <glommer@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com
Subject: Re: [PATCH 2/2] add sysctl for kvm wallclock sync
Date: Wed, 02 Sep 2009 08:54:37 +0200 [thread overview]
Message-ID: <4A9E16AD.8080508@redhat.com> (raw)
In-Reply-To: <1251805848-17451-3-git-send-email-glommer@redhat.com>
Glauber Costa wrote:
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index fc409e9..3a4e1bd 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -27,7 +27,7 @@
> #define KVM_SCALE 22
>
> static int kvmclock = 1;
> -static unsigned int kvm_wall_update_interval = 5;
> +unsigned int kvm_wall_update_interval = 5;
I think the overall idea is very interesting, but I also think that it should be
disabled by default. Because of the problems with time in virtualization,
people are already conditioned to run ntpd inside their guests, and this
kvmclock change will "fight" with ntpd. Also, the command "# date 09091323" (or
whatever) ceases to work like it does on bare-metal, so I think it has to be an
opt-in feature.
--
Chris Lalancette
next prev parent reply other threads:[~2009-09-02 6:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 11:50 [PATCH 0/2] Automatically grab wallclock time updates from hypervisor Glauber Costa
2009-09-01 11:50 ` [PATCH 1/2] keep guest wallclock in sync with host clock Glauber Costa
2009-09-01 11:50 ` [PATCH 2/2] add sysctl for kvm wallclock sync Glauber Costa
2009-09-02 6:54 ` Chris Lalancette [this message]
2009-09-02 11:31 ` Glauber Costa
2009-09-02 11:40 ` Avi Kivity
2009-09-02 11:44 ` [PATCH 1/2] keep guest wallclock in sync with host clock Avi Kivity
2009-09-02 12:21 ` Glauber Costa
2009-09-02 12:24 ` Avi Kivity
2009-09-02 12:48 ` Glauber Costa
2009-09-02 12:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A9E16AD.8080508@redhat.com \
--to=clalance@redhat.com \
--cc=avi@redhat.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).