extboot.bin required in git

extboot.bin required in git

[Jan Kiszka]

Hi Marcelo,

qemu-kvm's installation (0.11-rc as well as git head) is currently
broken /wrt extboot.bin. Please check some proper binary in as
pc-bios/extboot.bin.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

Re: extboot.bin required in git

[Avi Kivity]

On 09/02/2009 05:34 PM, Jan Kiszka wrote:
> Hi Marcelo,
>
> qemu-kvm's installation (0.11-rc as well as git head) is currently
> broken /wrt extboot.bin. Please check some proper binary in as
> pc-bios/extboot.bin.
>    

It's built at runtime.  Why check in a binary?

-- 
error compiling committee.c: too many arguments to function

Re: extboot.bin required in git

[Jan Kiszka]

Avi Kivity wrote:
> On 09/02/2009 05:34 PM, Jan Kiszka wrote:
>> Hi Marcelo,
>>
>> qemu-kvm's installation (0.11-rc as well as git head) is currently
>> broken /wrt extboot.bin. Please check some proper binary in as
>> pc-bios/extboot.bin.
>>    
> 
> It's built at runtime.  Why check in a binary?

First of all, it's a qemu policy (AFAIK): try to build the rom, use
shipped version if that doesn't work. And second, we (more precisely
qemu) does not seem to use the optionrom output for installation yet.
The latter is likely subject to change, but the former is expected to stay.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

Re: extboot.bin required in git

[Avi Kivity]

On 09/02/2009 05:51 PM, Jan Kiszka wrote:
> Avi Kivity wrote:
>    
>> On 09/02/2009 05:34 PM, Jan Kiszka wrote:
>>      
>>> Hi Marcelo,
>>>
>>> qemu-kvm's installation (0.11-rc as well as git head) is currently
>>> broken /wrt extboot.bin. Please check some proper binary in as
>>> pc-bios/extboot.bin.
>>>
>>>        
>> It's built at runtime.  Why check in a binary?
>>      
> First of all, it's a qemu policy (AFAIK): try to build the rom, use
> shipped version if that doesn't work.

Right, but this is qemu-kvm, which doesn't have the same issues 
(building an i386 target on non-i386).  When extboot is merged into 
qemu.git, they can add the build-if-possible-otherwise-use-shipped thing.

> And second, we (more precisely
> qemu) does not seem to use the optionrom output for installation yet.
> The latter is likely subject to change, but the former is expected to stay.
>    

We do, see 321b6ef91.

-- 
error compiling committee.c: too many arguments to function

Re: extboot.bin required in git

[Jan Kiszka]

Avi Kivity wrote:
> On 09/02/2009 05:51 PM, Jan Kiszka wrote:
>> Avi Kivity wrote:
>>    
>>> On 09/02/2009 05:34 PM, Jan Kiszka wrote:
>>>      
>>>> Hi Marcelo,
>>>>
>>>> qemu-kvm's installation (0.11-rc as well as git head) is currently
>>>> broken /wrt extboot.bin. Please check some proper binary in as
>>>> pc-bios/extboot.bin.
>>>>
>>>>        
>>> It's built at runtime.  Why check in a binary?
>>>      
>> First of all, it's a qemu policy (AFAIK): try to build the rom, use
>> shipped version if that doesn't work.
> 
> Right, but this is qemu-kvm, which doesn't have the same issues 
> (building an i386 target on non-i386).  When extboot is merged into 
> qemu.git, they can add the build-if-possible-otherwise-use-shipped thing.

Well, people may expect qemu-kvm's source tree to build properly also
for non-kvm usage. But this is not that important for now.

> 
>> And second, we (more precisely
>> qemu) does not seem to use the optionrom output for installation yet.
>> The latter is likely subject to change, but the former is expected to stay.
>>    
> 
> We do, see 321b6ef91.

Ah, I see: some out-of-tree build bug. Will fix.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

Re: extboot.bin required in git

[Jan Kiszka]

Jan Kiszka wrote:
> Avi Kivity wrote:
>> On 09/02/2009 05:51 PM, Jan Kiszka wrote:
>>> Avi Kivity wrote:
>>>    
>>>> On 09/02/2009 05:34 PM, Jan Kiszka wrote:
>>>>      
>>>>> Hi Marcelo,
>>>>>
>>>>> qemu-kvm's installation (0.11-rc as well as git head) is currently
>>>>> broken /wrt extboot.bin. Please check some proper binary in as
>>>>> pc-bios/extboot.bin.
>>>>>
>>>>>        
>>>> It's built at runtime.  Why check in a binary?
>>>>      
>>> First of all, it's a qemu policy (AFAIK): try to build the rom, use
>>> shipped version if that doesn't work.
>> Right, but this is qemu-kvm, which doesn't have the same issues 
>> (building an i386 target on non-i386).  When extboot is merged into 
>> qemu.git, they can add the build-if-possible-otherwise-use-shipped thing.
> 
> Well, people may expect qemu-kvm's source tree to build properly also
> for non-kvm usage. But this is not that important for now.

... it just requires another patch to qemu's Makefile. Well.

> 
>>> And second, we (more precisely
>>> qemu) does not seem to use the optionrom output for installation yet.
>>> The latter is likely subject to change, but the former is expected to stay.
>>>    
>> We do, see 321b6ef91.
> 
> Ah, I see: some out-of-tree build bug. Will fix.

And this patch is missing in master, isn't it?

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

Re: extboot.bin required in git

[Avi Kivity]

On 09/02/2009 06:26 PM, Jan Kiszka wrote:
> Well, people may expect qemu-kvm's source tree to build properly also
> for non-kvm usage. But this is not that important for now.
>    

It's not tested for non-kvm usage unfortunately.

> Ah, I see: some out-of-tree build bug. Will fix.
>
>    

That too is untested.  Thanks.

-- 
error compiling committee.c: too many arguments to function

Re: extboot.bin required in git

[Avi Kivity]

On 09/02/2009 06:31 PM, Jan Kiszka wrote:
>
>> Ah, I see: some out-of-tree build bug. Will fix.
>>      
> And this patch is missing in master, isn't it?
>    

IIRC it works in master somehow.

-- 
error compiling committee.c: too many arguments to function

Re: extboot.bin required in git

[Jan Kiszka]

Avi Kivity wrote:
> On 09/02/2009 06:31 PM, Jan Kiszka wrote:
>>> Ah, I see: some out-of-tree build bug. Will fix.
>>>      
>> And this patch is missing in master, isn't it?
>>    
> 
> IIRC it works in master somehow.
> 

Old extboot.bin still hanging around in your pc-bios folder...? :)

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

Re: extboot.bin required in git

[Avi Kivity]

On 09/02/2009 07:17 PM, Jan Kiszka wrote:
>> IIRC it works in master somehow.
>>
>>      
> Old extboot.bin still hanging around in your pc-bios folder...? :)
>
>    

I'm sure I deleted them... but can't argue with reality.

-- 
error compiling committee.c: too many arguments to function