Re: [PATCH 2/6] Nested VMX patch 2 implements vmclear

[Avi Kivity <avi@redhat.com>]

On 09/02/2009 06:38 PM, oritw@il.ibm.com wrote:
> From: Orit Wasserman<oritw@il.ibm.com>
>
> ---
>   arch/x86/kvm/vmx.c |   24 +++++++++++++++++++++++-
>   1 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index abba325..2b1fc3b 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -70,6 +70,8 @@ struct vmcs {
>   struct nested_vmx {
>   	/* Has the level1 guest done vmon? */
>   	bool vmon;
> +	/* Has the level1 guest done vmclear? */
> +	bool vmclear;
>   };
>    

Doesn't seem these two belong in the same structure - vmclear is 
per-vmcs... but you're probably aware of that with the multi-guest 
support coming.


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.