From mboxrd@z Thu Jan  1 00:00:00 1970
From: Uri Lublin <uril@redhat.com>
Subject: Re: [KVM-AUTOTEST PATCH 0/2] Add KSM test
Date: Mon, 07 Sep 2009 15:37:53 +0300
Message-ID: <4AA4FEA1.9040501@redhat.com>
References: <4A9B97E5.3000109@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-2;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: KVM list <kvm@vger.kernel.org>,
	Autotest mailing list <autotest@test.kernel.org>
To: =?ISO-8859-2?Q?Luk=E1=B9_Doktor?= <ldoktor@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:24003 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750844AbZIGMkB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 7 Sep 2009 08:40:01 -0400
In-Reply-To: <4A9B97E5.3000109@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 08/31/2009 12:29 PM, Luk=E1=B9 Doktor wrote:
> This patch adds KSM test. We faced many difficulties which weren't
> solvable by regular ways so please take a look and comment.

Hello Lukas,

Can you please provide reviewers with some more information:
1. What does your test do. Please briefly outline the test.
    What are the different steps, what are parallel/serial, etc.
2. What do the configuration parameters represent.
    - Also, is there a name mismatch ksm_ratio ?
3. Why do you communicate with your guest application using sockets ?
    I think it would be better to communicate with stdin/stdout (on the
    application) and session.sendline/session.read_until_last_line_matc=
hes.
4. With regards to the allocator program on the guest:
    - What is the difference between "random" and "static random"
       - is it just the seed ?
       - how do you use them ?
    - Why do you implement your own rand functions?
5. Why don't you define the first VM in the configuration file, and
    clone it for all other VMs (memory is calculated during test ?).
    Also please use an existing function to find a "free" port, instead
       of hard coding the port number. (you don't need it if you
       switch to using stdin/stdout)
6. Please replace os.popen('cat file') with directly opening/reading th=
e file.
    - same for grep commands.
    - we should probably write a util-function for grepping a file, if =
one
      does not already exist.
7. What were the difficulties you encountered and how did you solve the=
m ?
    - Host out-of-memory condition kills python program is one I saw.
      I think leaving some memory to the host is a good solution.

Thanks,
     Uri.