From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH -v2] QEMU-KVM: MCE: Relay UCR MCE to guest Date: Wed, 09 Sep 2009 15:16:07 +0300 Message-ID: <4AA79C87.4040003@redhat.com> References: <1252463282.5212.44.camel@yhuang-dev.sh.intel.com> <4AA79A31.9070600@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andi Kleen , Anthony Liguori , "kvm@vger.kernel.org" To: Huang Ying Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751546AbZIIMQJ (ORCPT ); Wed, 9 Sep 2009 08:16:09 -0400 In-Reply-To: <4AA79A31.9070600@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/09/2009 03:06 PM, Avi Kivity wrote: > On 09/09/2009 05:28 AM, Huang Ying wrote: >> UCR (uncorrected recovery) MCE is supported in recent Intel CPUs, >> where some hardware error such as some memory error can be reported >> without PCC (processor context corrupted). To recover from such MCE, >> the corresponding memory will be unmapped, and all processes accessing >> the memory will be killed via SIGBUS. >> >> For KVM, if QEMU/KVM is killed, all guest processes will be killed >> too. So we relay SIGBUS from host OS to guest system via a UCR MCE >> injection. Then guest OS can isolate corresponding memory and kill >> necessary guest processes only. SIGBUS sent to main thread (not VCPU >> threads) will be broadcast to all VCPU threads as UCR MCE. >> >> v2: >> >> - Use qemu_ram_addr_from_host instead of self made one to covert from >> host address to guest RAM address. Thanks Anthony Liguori. >> > > Patch looks good, but can you clarify the following: Oh and I forgot - please make MCE injection optional. Some installations may prefer to kill the guest and have the virtualization management system restart it rather than trust the guest to handle the MCE properly. -- error compiling committee.c: too many arguments to function