From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] call kvm_cpu_synchronize_state() on target vcpu Date: Wed, 09 Sep 2009 18:41:55 +0300 Message-ID: <4AA7CCC3.70701@redhat.com> References: <20090909153309.GD22885@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31815 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbZIIPlx (ORCPT ); Wed, 9 Sep 2009 11:41:53 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n89Ffvnb022338 for ; Wed, 9 Sep 2009 11:41:57 -0400 In-Reply-To: <20090909153309.GD22885@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/09/2009 06:33 PM, Gleb Natapov wrote: > regs_modified logic doesn't work if io thread calls > kvm_cpu_synchronize_state() since kvm_arch_get_registers() > returns only after vcpu thread is back to kernel. Setting > regs_modified to 1 at this stage causes loading of wrong vcpu > state on the next vcpu_run(). > > -static inline void kvm_arch_get_registers(CPUState *env) > -{ > - kvm_save_registers(env); > - kvm_save_mpstate(env); > -} > - > Please don't drop this, it's part of upstream kvm support which we're supported to be moving towards. -- error compiling committee.c: too many arguments to function