From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 01/10] Add test device for use with the test suite Date: Mon, 14 Sep 2009 16:01:42 +0300 Message-ID: <4AAE3EB6.8010907@redhat.com> References: <1252855135-2519-1-git-send-email-avi@redhat.com> <1252855135-2519-2-git-send-email-avi@redhat.com> <4AAE3E32.7090508@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31261 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066AbZINNBn (ORCPT ); Mon, 14 Sep 2009 09:01:43 -0400 In-Reply-To: <4AAE3E32.7090508@codemonkey.ws> Sender: kvm-owner@vger.kernel.org List-ID: On 09/14/2009 03:59 PM, Anthony Liguori wrote: > Avi Kivity wrote: >> The test device implements: >> - a serial port (0xf1) >> - an exit port (0xf4) >> - a memory size port (0xd1) >> >> It is planned to replace these with the standard serial and firmware >> configuration ports. >> >> Signed-off-by: Avi Kivity > > Should be a qdev-based ISA device. Then a new option wouldn't be > needed as you could just use -device. It really shouldn't be at all. It's for transition only. > These tests should all be runnable against upstream tcg, no? Yes, and I plan to eventually submit them against qemu upstream. Note the access test fails, though it might be due to the test itself, not qemu. -- error compiling committee.c: too many arguments to function