From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: pci: is reset incomplete?
Date: Mon, 14 Sep 2009 12:15:29 -0500
Message-ID: <4AAE7A31.9080600@codemonkey.ws>
References: <20090914154822.GA3745@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>,
	qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>,
	kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-yx0-f171.google.com ([209.85.210.171]:40413 "EHLO
	mail-yx0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750901AbZINRPl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 14 Sep 2009 13:15:41 -0400
Received: by yxe1 with SMTP id 1so4134041yxe.21
        for <kvm@vger.kernel.org>; Mon, 14 Sep 2009 10:15:44 -0700 (PDT)
In-Reply-To: <20090914154822.GA3745@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Michael S. Tsirkin wrote:
> Hi!
> pci bus reset does not seem to clear pci config registers, such as BAR
> registers, or memory space enable, of the attached devices: it only
> clears the interrupt state.
>
> This seems wrong, but easy to fix.
>   

I don't think most pci devices reset their config space in their reset 
callbacks.

I would think that making most of the config space (if not the entire) 
qdev properties would make sense.  You can then get reset for free and 
it's possible for users to tweak things like class codes universally.

Regards,

Anthony Liguori

> Comments?
>
>