From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dor Laor Subject: Re: [KVM-AUTOTEST PATCH 1/2] Add KSM test Date: Wed, 16 Sep 2009 16:21:29 +0300 Message-ID: <4AB0E659.8000907@redhat.com> References: <1205086068.232401253106583969.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Reply-To: dlaor@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, autotest@test.kernel.org, Lukas Doktor To: Jiri Zupka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5034 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751148AbZIPNVU (ORCPT ); Wed, 16 Sep 2009 09:21:20 -0400 In-Reply-To: <1205086068.232401253106583969.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/16/2009 04:09 PM, Jiri Zupka wrote: > > ----- "Dor Laor" wrote: > >> On 09/15/2009 09:58 PM, Jiri Zupka wrote: >>>> After a quick review I have the following questions: >>>> 1. Why did you implement the guest tool in 'c' and not in python? >>>> Python is much simpler and you can share some code with the >> server. >>>> This 'test protocol' would also be easier to understand this >> way. >>> >>> We need speed and the precise control of allocate memory in pages. >>> >>>> 2. IMHO there is no need to use select, you can do blocking read. >>> >>> We replace socket communication by interactive program communication >> via ssh/telnet >>> >>>> 3. Also you can use plain malloc without the more complex ( a bit) >> mmap. >>> >>> We need address exactly the memory pages. We can't allow shift of >> the data in memory. >> >> You can use the tmpfs+dd idea instead of the specific program as I >> detailed before. Maybe some other binary can be used. My intention is >> to >> simplify the test/environment as much as possible. >> > > We need compatibility with others system, like Windows etc.. > We want to add support for others system in next version KSM is a host feature and should be agnostic to the guest. Also I don't think your code will compile on windows... > >> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe kvm" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html