From mboxrd@z Thu Jan  1 00:00:00 1970
From: "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 1/4] core, x86: Add user return notifiers
Date: Fri, 18 Sep 2009 11:14:04 -0700
Message-ID: <4AB3CDEC.5050902@zytor.com>
References: <1253105134-8862-1-git-send-email-avi@redhat.com> <1253105134-8862-2-git-send-email-avi@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: Ingo Molnar <mingo@elte.hu>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from terminus.zytor.com ([198.137.202.10]:48306 "EHLO
	terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757615AbZIRSOZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 18 Sep 2009 14:14:25 -0400
In-Reply-To: <1253105134-8862-2-git-send-email-avi@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 09/16/2009 05:45 AM, Avi Kivity wrote:
> Add a general per-cpu notifier that is called whenever the kernel is
> about to return to userspace.  The notifier uses a thread_info flag
> and existing checks, so there is no impact on user return or context
> switch fast paths.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>

The concept of this patch looks entirely sane, as does the code,
*except* for:

+#include <linux/user-return-notifier.h>

... missing header file, and ...

+obj-$(CONFIG_USER_RETURN_NOTIFIER) += user-return-notifier.o

... missing source file.

Could you fix the patch, please?

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.