From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 01/24] Don't disable werror unconditionally Date: Sat, 19 Sep 2009 13:13:26 +0300 Message-ID: <4AB4AEC6.4090201@redhat.com> References: <0ebec62b6a7196f970cd57cdcbcb850fdaa829bd.1253272938.git.quintela@redhat.com> <20090918190256.GA14562@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Juan Quintela , kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9746 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbZISKNY (ORCPT ); Sat, 19 Sep 2009 06:13:24 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8JADT88010404 for ; Sat, 19 Sep 2009 06:13:29 -0400 In-Reply-To: <20090918190256.GA14562@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: > On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: > >> Signed-off-by: Juan Quintela >> --- >> configure | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> >> diff --git a/configure b/configure >> index 97292d9..e6252a2 100755 >> --- a/configure >> +++ b/configure >> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then >> else >> werror="no" >> fi >> - # disable default werror for kvm >> - werror="no" >> fi >> >> if test "$werror" = "yes" ; then >> > Don't know why Avi added this. > The merge which introduced this also introduced warnings into qemu-kvm. If the warnings are gone, it's better to restore -Werror to upstream behaviour. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.