From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 01/24] Don't disable werror unconditionally Date: Sat, 19 Sep 2009 13:14:15 +0200 Message-ID: <4AB4BD07.3090601@web.de> References: <0ebec62b6a7196f970cd57cdcbcb850fdaa829bd.1253272938.git.quintela@redhat.com> <20090918190256.GA14562@amt.cnet> <4AB4AEC6.4090201@redhat.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEB95256C0EE42A57C901B8AE" Cc: Marcelo Tosatti , Juan Quintela , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:36236 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbZISLPK (ORCPT ); Sat, 19 Sep 2009 07:15:10 -0400 In-Reply-To: <4AB4AEC6.4090201@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEB95256C0EE42A57C901B8AE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > On 09/18/2009 10:02 PM, Marcelo Tosatti wrote: >> On Fri, Sep 18, 2009 at 01:41:10PM +0200, Juan Quintela wrote: >> =20 >>> Signed-off-by: Juan Quintela >>> --- >>> configure | 2 -- >>> 1 files changed, 0 insertions(+), 2 deletions(-) >>> >>> diff --git a/configure b/configure >>> index 97292d9..e6252a2 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -1758,8 +1758,6 @@ if test -z "$werror" ; then >>> else >>> werror=3D"no" >>> fi >>> - # disable default werror for kvm >>> - werror=3D"no" >>> fi >>> >>> if test "$werror" =3D "yes" ; then >>> =20 >> Don't know why Avi added this. >> =20 >=20 > The merge which introduced this also introduced warnings into qemu-kvm.= =20 > If the warnings are gone, it's better to restore -Werror to upstream > behaviour. >=20 --disable-kvm builds will fail, but maybe this motivates to clean up the related code. Jan --------------enigEB95256C0EE42A57C901B8AE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkq0vQsACgkQitSsb3rl5xSNyACeOaZddFz/xKpzxUecL1/N89fr GCEAoJ0jbyEO8ksLLmPtpVLRvhBwjLrs =d+h/ -----END PGP SIGNATURE----- --------------enigEB95256C0EE42A57C901B8AE--