From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH] x86: Pick up local arch trace header
Date: Sun, 20 Sep 2009 10:56:22 +0200
Message-ID: <4AB5EE36.9060506@web.de>
References: <4AB43F9C.50000@cisco.com> <4AB484A1.2060404@web.de> <4AB550A4.20105@cisco.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigBE4C1E3E688C4376497BF284"
Cc: kvm@vger.kernel.org
To: Aidan Marks <aidan@cisco.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate02.web.de ([217.72.192.227]:50235 "EHLO
	fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751254AbZITI5q (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 20 Sep 2009 04:57:46 -0400
In-Reply-To: <4AB550A4.20105@cisco.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigBE4C1E3E688C4376497BF284
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Aidan Marks wrote:
> Hi Jan
>=20
> thanks, applied your patch, getting further, but now missing mmutrace.h=
=2E..
>=20
> vger kvm-kmod-devel-88 # make
> make -C /lib/modules/2.6.31-gentoo/build M=3D`pwd` \
>                 LINUXINCLUDE=3D"-I`pwd`/include -Iinclude \
>                  -Iarch/x86/include -I`pwd`/include-compat \
>                 -include include/linux/autoconf.h \
>                 -include `pwd`/x86/external-module-compat.h " \
>                 "$@"
> make[1]: Entering directory `/usr/src/linux-2.6.31-gentoo'
>   LD      /tmp/kvm-kmod-devel-88/x86/built-in.o
>   CC [M]  /tmp/kvm-kmod-devel-88/x86/svm.o
>   CC [M]  /tmp/kvm-kmod-devel-88/x86/vmx.o
>   CC [M]  /tmp/kvm-kmod-devel-88/x86/vmx-debug.o
>   CC [M]  /tmp/kvm-kmod-devel-88/x86/kvm_main.o
>   CC [M]  /tmp/kvm-kmod-devel-88/x86/x86.o
>   CC [M]  /tmp/kvm-kmod-devel-88/x86/mmu.o
> In file included from /tmp/kvm-kmod-devel-88/x86/mmutrace.h:220,
>                  from /tmp/kvm-kmod-devel-88/x86/mmu.c:184:
> include/trace/define_trace.h:53:43: error: ./mmutrace.h: No such file o=
r
> directory
> make[3]: *** [/tmp/kvm-kmod-devel-88/x86/mmu.o] Error 1
> make[2]: *** [/tmp/kvm-kmod-devel-88/x86] Error 2
> make[1]: *** [_module_/tmp/kvm-kmod-devel-88] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.6.31-gentoo'
> make: *** [all] Error 2

Here is a better approach:

diff --git a/include/arch/x86/kvm b/include/arch/x86/kvm
new file mode 120000
index 0000000..c635817
--- /dev/null
+++ b/include/arch/x86/kvm
@@ -0,0 +1 @@
+../../../x86
\ No newline at end of file

I also pushed a kvm-kmod update for 2.6.31-based modules in my repos,
see

	git://git.kiszka.org/kvm-kmod.git queue

To use this one instead of devel-88, clone it and run

git submodule update --init
=2E/configure
make sync
make

Jan


--------------enigBE4C1E3E688C4376497BF284
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkq17joACgkQitSsb3rl5xQ3mwCaA25BUxSI7z+tmGEQSXR4Jbuj
5oIAn1ICP6lotFCu6WcjvgoFsxZ+/NJZ
=Nmp8
-----END PGP SIGNATURE-----

--------------enigBE4C1E3E688C4376497BF284--