From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] x86: Pick up local arch trace header Date: Sun, 20 Sep 2009 13:42:32 +0200 Message-ID: <4AB61528.5060002@web.de> References: <4AB43F9C.50000@cisco.com> <4AB484A1.2060404@web.de> <4AB550A4.20105@cisco.com> <4AB5EE36.9060506@web.de> <4AB60BB6.5040201@cisco.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig84D0F4FFC278CF8B4C34EF92" Cc: kvm@vger.kernel.org To: Aidan Marks Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:54469 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751044AbZITLnk (ORCPT ); Sun, 20 Sep 2009 07:43:40 -0400 In-Reply-To: <4AB60BB6.5040201@cisco.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig84D0F4FFC278CF8B4C34EF92 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Aidan Marks wrote: > Il 20/09/09 18:56, Jan Kiszka ha scritto: >> Aidan Marks wrote: >>> Hi Jan >>> >>> thanks, applied your patch, getting further, but now missing mmutrace= =2Eh... >>> >>> vger kvm-kmod-devel-88 # make >>> make -C /lib/modules/2.6.31-gentoo/build M=3D`pwd` \ >>> LINUXINCLUDE=3D"-I`pwd`/include -Iinclude \ >>> -Iarch/x86/include -I`pwd`/include-compat \ >>> -include include/linux/autoconf.h \ >>> -include `pwd`/x86/external-module-compat.h " \ >>> "$@" >>> make[1]: Entering directory `/usr/src/linux-2.6.31-gentoo' >>> LD /tmp/kvm-kmod-devel-88/x86/built-in.o >>> CC [M] /tmp/kvm-kmod-devel-88/x86/svm.o >>> CC [M] /tmp/kvm-kmod-devel-88/x86/vmx.o >>> CC [M] /tmp/kvm-kmod-devel-88/x86/vmx-debug.o >>> CC [M] /tmp/kvm-kmod-devel-88/x86/kvm_main.o >>> CC [M] /tmp/kvm-kmod-devel-88/x86/x86.o >>> CC [M] /tmp/kvm-kmod-devel-88/x86/mmu.o >>> In file included from /tmp/kvm-kmod-devel-88/x86/mmutrace.h:220, >>> from /tmp/kvm-kmod-devel-88/x86/mmu.c:184: >>> include/trace/define_trace.h:53:43: error: ./mmutrace.h: No such file= or >>> directory >>> make[3]: *** [/tmp/kvm-kmod-devel-88/x86/mmu.o] Error 1 >>> make[2]: *** [/tmp/kvm-kmod-devel-88/x86] Error 2 >>> make[1]: *** [_module_/tmp/kvm-kmod-devel-88] Error 2 >>> make[1]: Leaving directory `/usr/src/linux-2.6.31-gentoo' >>> make: *** [all] Error 2 >> Here is a better approach: >> >> diff --git a/include/arch/x86/kvm b/include/arch/x86/kvm >> new file mode 120000 >> index 0000000..c635817 >> --- /dev/null >> +++ b/include/arch/x86/kvm >> @@ -0,0 +1 @@ >> +../../../x86 >> \ No newline at end of file >> >> I also pushed a kvm-kmod update for 2.6.31-based modules in my repos, >> see >> >> git://git.kiszka.org/kvm-kmod.git queue >> >> To use this one instead of devel-88, clone it and run >> >> git submodule update --init >> ./configure >> make sync >> make >> >> Jan >> >=20 > Hi Jan >=20 >=20 > $ git clone git://git.kiszka.org/kvm-kmod.git > Initialized empty Git repository in /tmp/kvm-kmod/.git/ > remote: Counting objects: 449, done. > remote: Compressing objects: 100% (217/217), done. > remote: Total 449 (delta 262), reused 374 (delta 214) > Receiving objects: 100% (449/449), 99.59 KiB | 38 KiB/s, done. > Resolving deltas: 100% (262/262), done. > $ cd kvm-kmod > $ git submodule update --init > Submodule 'linux-2.6' (git://git.kiszka.org/kvm.git) registered for pat= h > 'linux-2.6' > Initialized empty Git repository in /tmp/kvm-kmod/linux-2.6/.git/ > fatal: The remote end hung up unexpectedly > Clone of 'git://git.kiszka.org/kvm.git' into submodule path 'linux-2.6'= > failed > $ >=20 > :( Ah, my fault. That's because your 'origin' is now kiszka.org. Go to kvm-kmod/.git/config and update the submodule url to git://git.kernel.org/pub/scm/virt/kvm/kvm.git. Then do a 'git submodule update' and proceed with the other steps. >=20 > so i backed out the original patch and applied your new patch to > devel-88 instead. >=20 > ok it compiles but now I get unknown symbols warnings below. this > occurs with or without --kerneldir. >=20 > [snip] > Building modules, stage 2. > MODPOST 3 modules > WARNING: "__tracepoint_kvm_mmu_paging_element" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_mmu_sync_page" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_mmio" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_mmu_set_accessed_bit" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_exit" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_pio" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_mmu_zap_page" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_pic_set_irq" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_cpuid" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_mmu_unsync_page" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_msr" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_set_irq" [/tmp/kvm-kmod-devel-88/x86/kvm.ko]= > undefined! > WARNING: "__tracepoint_kvm_apic_accept_irq" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_inj_virq" [/tmp/kvm-kmod-devel-88/x86/kvm.ko= ] > undefined! > WARNING: "__tracepoint_kvm_hypercall" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_page_fault" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_entry" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_apic" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_ioapic_set_irq" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_apic_ipi" [/tmp/kvm-kmod-devel-88/x86/kvm.ko= ] > undefined! > WARNING: "__tracepoint_kvm_cr" [/tmp/kvm-kmod-devel-88/x86/kvm.ko] > undefined! > WARNING: "__tracepoint_kvm_ack_irq" [/tmp/kvm-kmod-devel-88/x86/kvm.ko]= > undefined! > WARNING: "__tracepoint_kvm_mmu_walker_error" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_mmu_get_page" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_mmu_set_dirty_bit" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_mmu_pagetable_walk" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > WARNING: "__tracepoint_kvm_msi_set_irq" > [/tmp/kvm-kmod-devel-88/x86/kvm.ko] undefined! > CC /tmp/kvm-kmod-devel-88/x86/kvm-amd.mod.o > LD [M] /tmp/kvm-kmod-devel-88/x86/kvm-amd.ko > CC /tmp/kvm-kmod-devel-88/x86/kvm-intel.mod.o > LD [M] /tmp/kvm-kmod-devel-88/x86/kvm-intel.ko > CC /tmp/kvm-kmod-devel-88/x86/kvm.mod.o > LD [M] /tmp/kvm-kmod-devel-88/x86/kvm.ko > make[1]: Leaving directory `/usr/src/linux-2.6.31-gentoo' I think (hope) that this is due to issues which are fixed in latest kvm-kmod. Let us try to get the git version running first as it shall be released as kvm-kmod-2.6.31 soon. Jan --------------enig84D0F4FFC278CF8B4C34EF92 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkq2FSwACgkQitSsb3rl5xTwjACgquKxkxwZtsNhCWWV26MvxwtU XWwAn0s2mxq6fuSU6fsQGzEDGeNQS+Gc =IfDC -----END PGP SIGNATURE----- --------------enig84D0F4FFC278CF8B4C34EF92--