From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH] x86: Pick up local arch trace header Date: Sun, 20 Sep 2009 15:24:04 +0200 Message-ID: <4AB62CF4.9040103@web.de> References: <4AB43F9C.50000@cisco.com> <4AB484A1.2060404@web.de> <4AB550A4.20105@cisco.com> <4AB5EE36.9060506@web.de> <4AB60BB6.5040201@cisco.com> <4AB61528.5060002@web.de> <4AB62654.5090105@cisco.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigA642E6E69C916A6C856A2FFD" Cc: kvm@vger.kernel.org To: Aidan Marks Return-path: Received: from fmmailgate02.web.de ([217.72.192.227]:42816 "EHLO fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752237AbZITNjN (ORCPT ); Sun, 20 Sep 2009 09:39:13 -0400 In-Reply-To: <4AB62654.5090105@cisco.com> Sender: kvm-owner@vger.kernel.org List-ID: This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigA642E6E69C916A6C856A2FFD Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Aidan Marks wrote: >=20 > Il 20/09/09 21:42, Jan Kiszka ha scritto: >> Aidan Marks wrote: >>> Il 20/09/09 18:56, Jan Kiszka ha scritto: >>>> Aidan Marks wrote: >>>>> Hi Jan >>>>> >>>>> thanks, applied your patch, getting further, but now missing mmutra= ce.h... >>>>> >>>>> vger kvm-kmod-devel-88 # make >>>>> make -C /lib/modules/2.6.31-gentoo/build M=3D`pwd` \ >>>>> LINUXINCLUDE=3D"-I`pwd`/include -Iinclude \ >>>>> -Iarch/x86/include -I`pwd`/include-compat \ >>>>> -include include/linux/autoconf.h \ >>>>> -include `pwd`/x86/external-module-compat.h " \ >>>>> "$@" >>>>> make[1]: Entering directory `/usr/src/linux-2.6.31-gentoo' >>>>> LD /tmp/kvm-kmod-devel-88/x86/built-in.o >>>>> CC [M] /tmp/kvm-kmod-devel-88/x86/svm.o >>>>> CC [M] /tmp/kvm-kmod-devel-88/x86/vmx.o >>>>> CC [M] /tmp/kvm-kmod-devel-88/x86/vmx-debug.o >>>>> CC [M] /tmp/kvm-kmod-devel-88/x86/kvm_main.o >>>>> CC [M] /tmp/kvm-kmod-devel-88/x86/x86.o >>>>> CC [M] /tmp/kvm-kmod-devel-88/x86/mmu.o >>>>> In file included from /tmp/kvm-kmod-devel-88/x86/mmutrace.h:220, >>>>> from /tmp/kvm-kmod-devel-88/x86/mmu.c:184: >>>>> include/trace/define_trace.h:53:43: error: ./mmutrace.h: No such fi= le or >>>>> directory >>>>> make[3]: *** [/tmp/kvm-kmod-devel-88/x86/mmu.o] Error 1 >>>>> make[2]: *** [/tmp/kvm-kmod-devel-88/x86] Error 2 >>>>> make[1]: *** [_module_/tmp/kvm-kmod-devel-88] Error 2 >>>>> make[1]: Leaving directory `/usr/src/linux-2.6.31-gentoo' >>>>> make: *** [all] Error 2 >>>> Here is a better approach: >>>> >>>> diff --git a/include/arch/x86/kvm b/include/arch/x86/kvm >>>> new file mode 120000 >>>> index 0000000..c635817 >>>> --- /dev/null >>>> +++ b/include/arch/x86/kvm >>>> @@ -0,0 +1 @@ >>>> +../../../x86 >>>> \ No newline at end of file >>>> >>>> I also pushed a kvm-kmod update for 2.6.31-based modules in my repos= , >>>> see >>>> >>>> git://git.kiszka.org/kvm-kmod.git queue >>>> >>>> To use this one instead of devel-88, clone it and run >>>> >>>> git submodule update --init >>>> ./configure >>>> make sync >>>> make >>>> >>>> Jan >>>> >>> Hi Jan >>> >>> >>> $ git clone git://git.kiszka.org/kvm-kmod.git >>> Initialized empty Git repository in /tmp/kvm-kmod/.git/ >>> remote: Counting objects: 449, done. >>> remote: Compressing objects: 100% (217/217), done. >>> remote: Total 449 (delta 262), reused 374 (delta 214) >>> Receiving objects: 100% (449/449), 99.59 KiB | 38 KiB/s, done. >>> Resolving deltas: 100% (262/262), done. >>> $ cd kvm-kmod >>> $ git submodule update --init >>> Submodule 'linux-2.6' (git://git.kiszka.org/kvm.git) registered for p= ath >>> 'linux-2.6' >>> Initialized empty Git repository in /tmp/kvm-kmod/linux-2.6/.git/ >>> fatal: The remote end hung up unexpectedly >>> Clone of 'git://git.kiszka.org/kvm.git' into submodule path 'linux-2.= 6' >>> failed >>> $ >>> >>> :( >> Ah, my fault. That's because your 'origin' is now kiszka.org. Go to >> kvm-kmod/.git/config and update the submodule url to >> git://git.kernel.org/pub/scm/virt/kvm/kvm.git. Then do a 'git submodul= e >> update' and proceed with the other steps. >> >=20 > Hi Jan >=20 > ok thanks (sorry, new to git). >=20 > unfortunately, still getting the mmutrace.h failure (same error without= > kerneldir): [...] OK, there was more git foo hidden behind "clone my tree": Once you cloned it, you are still on the master branch. You then have to checkout that 'queue' branch I was referring to: =2E../kvm-kmod> git checkout -b queue origin/queue Now you have to run 'git submodule update' once again as my queue uses a different revision from kvm.git. But then everything should really work. Jan --------------enigA642E6E69C916A6C856A2FFD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkq2LPkACgkQitSsb3rl5xT04gCfa/46BJ8ocF6Pgrnl0/v0s8oA iVUAoONSuyuCBJEcxO1wV1copXsQnDMi =UZrC -----END PGP SIGNATURE----- --------------enigA642E6E69C916A6C856A2FFD--