From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 04/24] piix4_dev is not used for pc's Date: Mon, 21 Sep 2009 12:45:00 +0300 Message-ID: <4AB74B1C.4000208@redhat.com> References: <20090918190541.GB14562@amt.cnet> <4AB74316.6060107@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Juan Quintela Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19204 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755389AbZIUJpB (ORCPT ); Mon, 21 Sep 2009 05:45:01 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8L9j59Q027973 for ; Mon, 21 Sep 2009 05:45:05 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 09/21/2009 12:37 PM, Juan Quintela wrote: > Avi Kivity wrote: > >> On 09/19/2009 12:42 AM, Juan Quintela wrote: >> >>> >>>> Not applying because its dead code with the current state of pc.c >>>> configuration but this prevents one to use piix4. >>>> >>>> >>> piix4 is not used for pci irq assignement in pc. It is only used on >>> mips. I am the one that split the file in qemu upstream. piix4 and >>> piix3 are the same from the irq point of view. >>> >>> next pc chipset is not going to be piix4 :) >>> >>> >> I agree with Marcelo - even if mips never gains device assignment or >> pc never uses piix4, the code is more complete the way it is. >> > Ok, it forces to compile back piix4.o in a pc. In qemu upstream piix4.o > is only compiled for MIPS. That is the reason why I noticed. (Yes, I am > the one that did the split). > Ah, in that case it's better to apply the patch. Thanks. -- error compiling committee.c: too many arguments to function