From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 04/10] KVM: split kvm_arch_set_memory_region into prepare and commit Date: Tue, 22 Sep 2009 09:40:56 +0300 Message-ID: <4AB87178.7050402@redhat.com> References: <20090921233711.213665413@amt.cnet> <20090921234124.294262283@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27665 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755226AbZIVGkz (ORCPT ); Tue, 22 Sep 2009 02:40:55 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8M6exXt005433 for ; Tue, 22 Sep 2009 02:40:59 -0400 In-Reply-To: <20090921234124.294262283@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 09/22/2009 02:37 AM, Marcelo Tosatti wrote: > Required for SRCU convertion later. > > My feeling is that prepare/commit can be common code and only some small bits (like allocating x86 rmaps) can be arch specific. That's for another patchset though. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.