From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 08/10] KVM: x86: switch kvm_set_memory_alias to SRCU update Date: Tue, 22 Sep 2009 10:04:25 +0300 Message-ID: <4AB876F9.8030701@redhat.com> References: <20090921233711.213665413@amt.cnet> <20090921234124.709624825@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754725AbZIVHEX (ORCPT ); Tue, 22 Sep 2009 03:04:23 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8M74RZL031353 for ; Tue, 22 Sep 2009 03:04:27 -0400 In-Reply-To: <20090921234124.709624825@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 09/22/2009 02:37 AM, Marcelo Tosatti wrote: > Using a similar two-step procedure as for memslots. > > > > - gfn = unalias_gfn(kvm, gfn); > + gfn = unalias_gfn(kvm, gfn, false); > To improve readability suggest two names, maybe unalias_gfn() and unalias_gfn_instantiation(). boolean parameters are hard to read at the call site. Also we've discussed in the past converting aliases to private slots (and also echo aliases >> feature-removal-schedule.txt); maybe that is an easier way of verifying everything still works. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.