From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 00/10] RFC: switch vcpu context to use SRCU Date: Tue, 22 Sep 2009 10:09:02 +0300 Message-ID: <4AB8780E.3050905@redhat.com> References: <20090921233711.213665413@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59437 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755319AbZIVHJB (ORCPT ); Tue, 22 Sep 2009 03:09:01 -0400 Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8M795oa012324 for ; Tue, 22 Sep 2009 03:09:05 -0400 In-Reply-To: <20090921233711.213665413@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 09/22/2009 02:37 AM, Marcelo Tosatti wrote: > Improves vmexit latency by ~= 13% on UP guest. > > Still requires decent stress testing and careful review, but posting for > early comments. > Okay, looks very nice. The only real problem I see is mmu_lock for mark_dirty(), the other comments are more or less cosmetic. Please copy the kvm-arch lists and maintainers on the next round so they can review this as well. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.