From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] Don't call cpu_synchronize_state() in apic_init_reset()
Date: Wed, 23 Sep 2009 12:00:44 +0300 [thread overview]
Message-ID: <4AB9E3BC.7060304@redhat.com> (raw)
In-Reply-To: <1253631112-26124-3-git-send-email-gleb@redhat.com>
On 09/22/2009 05:51 PM, Gleb Natapov wrote:
> Each caller of the function already calls it.
>
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
> ---
> hw/apic.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/hw/apic.c b/hw/apic.c
> index 3a2e128..a9d1fb8 100644
> --- a/hw/apic.c
> +++ b/hw/apic.c
> @@ -488,7 +488,6 @@ void apic_init_reset(CPUState *env)
> if (!s)
> return;
>
> - cpu_synchronize_state(env);
> s->tpr = 0;
> s->spurious_vec = 0xff;
> s->log_dest = 0;
>
Still, it's safer to live this in.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-23 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 14:51 [PATCH] Update halted state from mpstate only in case of inkernel irq chip Gleb Natapov
2009-09-22 14:51 ` [PATCH] Don't call kvm_cpu_synchronize_state() if there is no irqchip events to process Gleb Natapov
2009-09-23 9:00 ` Avi Kivity
2009-09-22 14:51 ` [PATCH] Don't call cpu_synchronize_state() in apic_init_reset() Gleb Natapov
2009-09-23 9:00 ` Avi Kivity [this message]
2009-09-23 15:07 ` Jan Kiszka
2009-09-23 15:17 ` Avi Kivity
2009-09-23 15:45 ` Jan Kiszka
2009-09-24 7:53 ` Avi Kivity
2009-09-24 8:03 ` Gleb Natapov
2009-09-24 8:15 ` Jan Kiszka
2009-09-24 8:30 ` Gleb Natapov
2009-09-24 8:59 ` Jan Kiszka
2009-09-24 9:11 ` Gleb Natapov
2009-09-25 15:03 ` Jan Kiszka
2009-09-24 8:24 ` Avi Kivity
2009-09-23 9:00 ` [PATCH] Update halted state from mpstate only in case of inkernel irq chip Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AB9E3BC.7060304@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).