From: Avi Kivity <avi@redhat.com>
To: "Zhai, Edwin" <edwin.zhai@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH] [RESEND] KVM:VMX: Add support for Pause-Loop Exiting
Date: Wed, 23 Sep 2009 17:09:38 +0300 [thread overview]
Message-ID: <4ABA2C22.7020000@redhat.com> (raw)
In-Reply-To: <4ABA2AD7.6080008@intel.com>
On 09/23/2009 05:04 PM, Zhai, Edwin wrote:
> Avi,
>
> This is the patch to enable PLE, which depends on the a small change
> of Linux scheduler
> (see http://lkml.org/lkml/2009/5/20/447).
>
> According to our discussion last time, one missing part is that if PLE
> exit, pick up an unscheduled vcpu at random and schedule it. But
> further investigation found that:
> 1. KVM is hard to know the schedule state for each vcpu.
> 2. Linux scheduler has no existed API can be used to pull a specific
> task to this cpu, so we need more changes to the common scheduler.
> So I prefer current simple way: just give up current cpu time.
>
> If no objection, I'll try to push common scheduler change first to
> linux.
We haven't sorted out what is the correct thing to do here. I think we
should go for a directed yield, but until we have it, you can use
hrtimers to sleep for 100 microseconds and hope the holding vcpu will
get scheduled. Even if it doesn't, we're only wasting a few percent cpu
time instead of spinning.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2009-09-23 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-23 14:04 [PATCH] [RESEND] KVM:VMX: Add support for Pause-Loop Exiting Zhai, Edwin
2009-09-23 14:09 ` Avi Kivity [this message]
2009-09-25 1:11 ` Zhai, Edwin
2009-09-27 8:28 ` Avi Kivity
2009-09-28 9:33 ` Zhai, Edwin
2009-09-29 12:05 ` Zhai, Edwin
2009-09-29 13:34 ` Avi Kivity
2009-09-30 1:01 ` Zhai, Edwin
2009-09-30 6:28 ` Avi Kivity
2009-09-30 16:22 ` Marcelo Tosatti
2009-10-02 18:28 ` Marcelo Tosatti
2009-10-09 10:03 ` Zhai, Edwin
2009-10-11 15:34 ` Avi Kivity
2009-10-12 19:13 ` Marcelo Tosatti
2009-09-25 20:43 ` Joerg Roedel
2009-09-27 8:31 ` Avi Kivity
2009-09-27 13:46 ` Joerg Roedel
2009-09-27 13:47 ` Avi Kivity
2009-09-27 14:07 ` Joerg Roedel
2009-09-27 14:18 ` Avi Kivity
2009-09-27 14:53 ` Joerg Roedel
2009-09-29 16:46 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABA2C22.7020000@redhat.com \
--to=avi@redhat.com \
--cc=edwin.zhai@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).