From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] qemu-kvm: Fix segfault on -no-kvm startup
Date: Sun, 27 Sep 2009 10:33:56 +0200 [thread overview]
Message-ID: <4ABF2374.1010303@redhat.com> (raw)
In-Reply-To: <4ABD13EF.7090403@web.de>
On 09/25/2009 10:03 PM, Jan Kiszka wrote:
> Gleb Natapov wrote:
>
>> On Fri, Sep 25, 2009 at 06:05:49PM +0200, Jan Kiszka wrote:
>>
>>> The check for in-kernel irqchip must be protected by kvm_enabled, and we
>>> have a different wrapper for it.
>>>
>>>
>> Why not move kvm_enabled() into kvm_irqchip_in_kernel()? It will return
>> false if !kvm_enabled().
>>
> Yes, possible. But I'm not sure if it's worth to refactor at this level.
>
In any case, fix bugs first, refactor later.
> I think the whole irqchip interface has to go through some broader
> refactoring when pushing it upstream. The result should either be a
> specific, in-kernel-irqchip apic device or generic wrapper services that
> cover all cases, is easily compiled away in the absence of KVM and avoid
> #ifdefs like below.
>
s/when/before/
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2009-09-27 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-25 16:05 [PATCH] qemu-kvm: Fix segfault on -no-kvm startup Jan Kiszka
2009-09-25 17:05 ` Gleb Natapov
2009-09-25 19:03 ` Jan Kiszka
2009-09-27 8:33 ` Avi Kivity [this message]
2009-09-27 8:33 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ABF2374.1010303@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).