From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch 2/2] test: vmexit: run parallel tests on each cpu Date: Tue, 29 Sep 2009 10:35:25 +0200 Message-ID: <4AC1C6CD.9000407@redhat.com> References: <20090928112208.841396420@redhat.com> <20090928112247.443732285@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10316 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753343AbZI2IfX (ORCPT ); Tue, 29 Sep 2009 04:35:23 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8T8ZRqG023915 for ; Tue, 29 Sep 2009 04:35:27 -0400 In-Reply-To: <20090928112247.443732285@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/28/2009 01:22 PM, Marcelo Tosatti wrote: > So one can measure SMP overhead. > > + > + for (n = cpu_count(); n> 0; n--) > + on_cpu(n-1, do_tests, 0, 0); > Should be done inside do_test(), so we can start the measurement on all cpus at the same time (right now, if some cpus calibrate earlier, they will finish sooner and the others will have an easier time). -- error compiling committee.c: too many arguments to function