kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Mark McLoughlin <markmc@redhat.com>
Cc: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream
Date: Wed, 30 Sep 2009 08:24:18 +0200	[thread overview]
Message-ID: <4AC2F992.5000202@redhat.com> (raw)
In-Reply-To: <1254257151.29022.11.camel@blaa>

On 09/29/2009 10:45 PM, Mark McLoughlin wrote:
> On Tue, 2009-05-05 at 09:56 +0100, Mark McLoughlin wrote:
>    
>> This commit:
>>
>>     commit 559a8f45f34cc50d1a60b4f67a06614d506b2e01
>>     Subject: Remove stray GSO code from virtio_net (Mark McLoughlin)
>>
>> Removed some GSO code from upstream qemu.git, but it needs to
>> be re-instated in qemu-kvm.git.
>>
>> Reported-by: Sridhar Samudrala<sri@us.ibm.com>
>> Signed-off-by: Mark McLoughlin<markmc@redhat.com>
>> ---
>>   hw/virtio-net.c |    5 +++++
>>   1 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/virtio-net.c b/hw/virtio-net.c
>> index ac8e030..e5d7add 100644
>> --- a/hw/virtio-net.c
>> +++ b/hw/virtio-net.c
>> @@ -424,6 +424,11 @@ static int receive_filter(VirtIONet *n, const uint8_t *buf, int size)
>>       if (n->promisc)
>>           return 1;
>>
>> +#ifdef TAP_VNET_HDR
>> +    if (tap_has_vnet_hdr(n->vc->vlan->first_client))
>> +        ptr += sizeof(struct virtio_net_hdr);
>> +#endif
>> +
>>       if (!memcmp(&ptr[12], vlan, sizeof(vlan))) {
>>           int vid = be16_to_cpup((uint16_t *)(ptr + 14))&  0xfff;
>>           if (!(n->vlans[vid>>  5]&  (1U<<  (vid&  0x1f))))
>>      
> I'm not sure[1] how we didn't notice, but this has been broken on the
> stable-0.10 branch since 0.10.3; please apply there too
>
>    

Thanks, we'll queue it on stable-0.10.

Anthony/Glauber, is 0.10.7 in the works?  If not, we'll release it as 
0.10.6.1.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


  parent reply	other threads:[~2009-09-30  6:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-04 16:50 virtio-net not working with the latest qemu-kvm git Sridhar Samudrala
2009-05-04 17:44 ` Alex Williamson
2009-05-05  8:56   ` [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream Mark McLoughlin
2009-05-06  9:11     ` Avi Kivity
2009-09-29 20:45     ` Mark McLoughlin
2009-09-29 20:47       ` Mark McLoughlin
2009-09-30  6:24       ` Avi Kivity [this message]
2009-09-30 11:24         ` Glauber Costa
2009-09-30 11:24           ` Mark McLoughlin
2009-09-30 13:01         ` Anthony Liguori
2009-09-30 13:51       ` Christoph Hellwig
2009-09-30 13:55         ` Avi Kivity
2009-09-30 13:59           ` Mark McLoughlin
2009-09-30 19:15             ` Gerd Hoffmann
2009-10-01  6:59               ` [Qemu-devel] " Mark McLoughlin
2009-10-01 16:49             ` Avi Kivity
2009-10-01 17:00               ` Mark McLoughlin
2009-10-01 17:04                 ` Avi Kivity
2009-05-05  8:56   ` virtio-net not working with the latest qemu-kvm git Mark McLoughlin
2009-05-06  9:12 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AC2F992.5000202@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=gcosta@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).