From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v4: kvm 1/4] Code motion. Separate timer intialization into an indepedent function. Date: Wed, 30 Sep 2009 10:45:25 +0200 Message-ID: <4AC31AA5.4060609@redhat.com> References: <4AC1C59F.6010703@redhat.com> <1254260317-3490-1-git-send-email-zamsden@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Marcelo Tosatti To: Zachary Amsden Return-path: In-Reply-To: <1254260317-3490-1-git-send-email-zamsden@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/29/2009 11:38 PM, Zachary Amsden wrote: > Signed-off-by: Zachary Amsden > Looks good. Is anything preventing us from unifying the constant_tsc and !same paths? We could just do a quick check in the notifier, see the tsc frequency hasn't changed, and return. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.