From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream Date: Wed, 30 Sep 2009 15:55:33 +0200 Message-ID: <4AC36355.8040908@redhat.com> References: <1241459088.26045.1.camel@lappy> <1241513785-28738-1-git-send-email-markmc@redhat.com> <1254257151.29022.11.camel@blaa> <20090930135144.GA29956@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mark McLoughlin , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Christoph Hellwig Return-path: Received: from mx1.redhat.com ([209.132.183.28]:65264 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863AbZI3Nzj (ORCPT ); Wed, 30 Sep 2009 09:55:39 -0400 In-Reply-To: <20090930135144.GA29956@infradead.org> Sender: kvm-owner@vger.kernel.org List-ID: On 09/30/2009 03:51 PM, Christoph Hellwig wrote: > I might sound like a broken record, but why isn't the full GSO support > for virtio-net upstream in qemu? > IIRC the current hacks are not upstream quality. The problem (again IIRC) is that the guest and host negotiate a protocol, but the qemu vlan model doesn't have a guest and a host, it has peers (possibly more than two), so a lot of translation has to take place if you have one peer supporting a guest feature and another not. IMO the best way out is to drop the vlan model. It has its uses, but they can all be implemented in other ways, and are all have minor usage compared to the business of getting data into and out of a guest. -- error compiling committee.c: too many arguments to function