From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] qemu-kvm: virtio-net: Re-instate GSO code removed upstream Date: Thu, 01 Oct 2009 19:04:18 +0200 Message-ID: <4AC4E112.1020709@redhat.com> References: <1241459088.26045.1.camel@lappy> <1241513785-28738-1-git-send-email-markmc@redhat.com> <1254257151.29022.11.camel@blaa> <20090930135144.GA29956@infradead.org> <4AC36355.8040908@redhat.com> <1254319160.3105.67.camel@blaa> <4AC4DDA7.9070708@redhat.com> <1254416426.2920.41.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , kvm@vger.kernel.org, qemu-devel@nongnu.org To: Mark McLoughlin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11363 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755340AbZJAREZ (ORCPT ); Thu, 1 Oct 2009 13:04:25 -0400 In-Reply-To: <1254416426.2920.41.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On 10/01/2009 07:00 PM, Mark McLoughlin wrote: > On Thu, 2009-10-01 at 18:49 +0200, Avi Kivity wrote: > >> On 09/30/2009 03:59 PM, Mark McLoughlin wrote: >> >>> I think we should keep the vlan stuff, just de-emphasise it. >>> >>> >> Maybe we should do what X.org does, break it silently and remove it some >> time later when no one complains. >> > Well, the 'silently' part isn't going to work now, is it? > Me and my big mouth. > Anyway, I'm sure at least Jan would notice if his 'dump' backend stopped > working > Patch it to use libpcap? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.