From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: Heads up: More user-unaccessible x86 states?
Date: Mon, 05 Oct 2009 14:34:04 +0200
Message-ID: <4AC9E7BC.2060803@redhat.com>
References: <4AC86404.3090209@web.de> <4AC87299.4040508@redhat.com> <4AC87E08.5070908@web.de> <4AC88BF2.7080200@redhat.com> <4AC8F282.3090307@web.de> <4AC98FBC.3030509@redhat.com> <4AC9A395.5010609@web.de> <4AC9B490.5020502@redhat.com> <4AC9D608.2000205@siemens.com> <4AC9E118.8030304@redhat.com> <4AC9E431.2050800@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm@vger.kernel.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:12695 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753488AbZJEMee (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 5 Oct 2009 08:34:34 -0400
In-Reply-To: <4AC9E431.2050800@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 10/05/2009 02:18 PM, Jan Kiszka wrote:
>
>> True pointers are no go since we have to deal with compat code (31/32
>> bit userspace calling into a 64 bit kernel).  Offsets into the state
>> structure are easier.
>>      
> So current KVM_GET_DIRTY_LOG is broken in the compat case...
>
>    

Yes, for big-endian 32/64 and s390.  There are some patches floating around.

> We'll probably have to deal with both. Therefore, I'm looking for a
> unified solution.
>
>    

array of

struct {
    __u16 type;
    __u16 offset;
} ?

-- 
error compiling committee.c: too many arguments to function