From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu-kvm: kvm headers update Date: Tue, 06 Oct 2009 11:51:45 +0200 Message-ID: <4ACB1331.7060505@redhat.com> References: <20091005094612.GA30068@redhat.com> <4ACA12FB.7030805@redhat.com> <20091005192720.GA3399@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60026 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756802AbZJFJwO (ORCPT ); Tue, 6 Oct 2009 05:52:14 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n969plX1025880 for ; Tue, 6 Oct 2009 05:51:48 -0400 In-Reply-To: <20091005192720.GA3399@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/05/2009 09:27 PM, Michael S. Tsirkin wrote: > > >> Why are you dropping these? Any dependencies on CONFIG_ will be broken. >> > Instead I included kvm_types which has these. > Oh, a side effect. Mind moving the CONFIG_* stuff to a separate header (which we can include using -include)? Separate patch please. -- error compiling committee.c: too many arguments to function