From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@siemens.com>
Subject: Re: [PATCH 1/3] qemu-kvm: fix build with KVM_CAP_SET_GUEST_DEBUG
Date: Wed, 07 Oct 2009 14:16:32 +0200
Message-ID: <4ACC86A0.9080309@siemens.com>
References: <cover.1254914295.git.mst@redhat.com> <20091007111917.GB20835@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: avi@redhat.com, kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from david.siemens.de ([192.35.17.14]:22315 "EHLO david.siemens.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932668AbZJGMRX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 7 Oct 2009 08:17:23 -0400
In-Reply-To: <20091007111917.GB20835@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Michael S. Tsirkin wrote:
> Fix build with KVM_CAP_SET_GUEST_DEBUG: use QLIST macro
> to declare list head.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  qemu-kvm.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-kvm.h b/qemu-kvm.h
> index 4523e25..d6748c7 100644
> --- a/qemu-kvm.h
> +++ b/qemu-kvm.h
> @@ -1229,7 +1229,7 @@ typedef struct KVMState {
>      int broken_set_mem_region;
>      int migration_log;
>  #ifdef KVM_CAP_SET_GUEST_DEBUG
> -    struct kvm_sw_breakpoint_head kvm_sw_breakpoints;
> +    QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints;
>  #endif
>      struct kvm_context kvm_context;
>  } KVMState;

If it's required here I bet we need this upstream too, right? Then
please also file a corresponding patch for qemu.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux