From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/3] qemu-kvm: fix build with KVM_CAP_SET_GUEST_DEBUG Date: Wed, 07 Oct 2009 14:23:28 +0200 Message-ID: <4ACC8840.1060806@siemens.com> References: <20091007111917.GB20835@redhat.com> <4ACC86A0.9080309@siemens.com> <20091007121831.GB31484@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "avi@redhat.com" , "kvm@vger.kernel.org" To: "Michael S. Tsirkin" Return-path: Received: from david.siemens.de ([192.35.17.14]:24605 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932700AbZJGMYS (ORCPT ); Wed, 7 Oct 2009 08:24:18 -0400 In-Reply-To: <20091007121831.GB31484@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Michael S. Tsirkin wrote: > On Wed, Oct 07, 2009 at 02:16:32PM +0200, Jan Kiszka wrote: >> Michael S. Tsirkin wrote: >>> Fix build with KVM_CAP_SET_GUEST_DEBUG: use QLIST macro >>> to declare list head. >>> >>> Signed-off-by: Michael S. Tsirkin >>> --- >>> qemu-kvm.h | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/qemu-kvm.h b/qemu-kvm.h >>> index 4523e25..d6748c7 100644 >>> --- a/qemu-kvm.h >>> +++ b/qemu-kvm.h >>> @@ -1229,7 +1229,7 @@ typedef struct KVMState { >>> int broken_set_mem_region; >>> int migration_log; >>> #ifdef KVM_CAP_SET_GUEST_DEBUG >>> - struct kvm_sw_breakpoint_head kvm_sw_breakpoints; >>> + QTAILQ_HEAD(, kvm_sw_breakpoint) kvm_sw_breakpoints; >>> #endif >>> struct kvm_context kvm_context; >>> } KVMState; >> If it's required here I bet we need this upstream too, right? > > No, upstream does not have qemu-kvm.h > All these files are qemu-kvm only. > upstream builds fine as is. Upstream has KVMState, too, but it also has a cleaner header structuring than qemu-kvm (as the latter is morphing towards to former). So yes, this is a qemu-kvm-only workaround. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux