From: Avi Kivity <avi@redhat.com>
To: Robert Henry <rrh@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: bad? encoding for KVM_SET_IRQCHIP
Date: Thu, 08 Oct 2009 14:41:38 +0200 [thread overview]
Message-ID: <4ACDDE02.3060706@redhat.com> (raw)
In-Reply-To: <c8e291640910051540g4a9a68d6jaf91939cbf700a6e@mail.gmail.com>
On 10/06/2009 12:40 AM, Robert Henry wrote:
> I am concerned about an apparent misencoding for ioctl KVM_SET_IRQCHIP
>
> kvm/include/linux/kvm.h defines KVM_SET_IRQCHIP as
>
> #define KVM_SET_IRQCHIP _IOR(KVMIO, 0x63, struct kvm_irqchip)
>
> But the verb "SET" in the ioctl name would imply that the ioctl
> encoding constructor should be _IOW, not _IOR.
>
> Note also that KVM_SET_PIT seems to have the same encoding issue.
>
>
Yes, there are some bad encodings for the kvm ioctls. Unfortunately
Linux doesn't enforce the directions, so it wasn't discovered in time.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2009-10-08 12:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 22:40 bad? encoding for KVM_SET_IRQCHIP Robert Henry
2009-10-08 12:41 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ACDDE02.3060706@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=rrh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).