From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: bad? encoding for KVM_SET_IRQCHIP Date: Thu, 08 Oct 2009 14:41:38 +0200 Message-ID: <4ACDDE02.3060706@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Robert Henry Return-path: Received: from mx1.redhat.com ([209.132.183.28]:31250 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757687AbZJHMmK (ORCPT ); Thu, 8 Oct 2009 08:42:10 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 10/06/2009 12:40 AM, Robert Henry wrote: > I am concerned about an apparent misencoding for ioctl KVM_SET_IRQCHIP > > kvm/include/linux/kvm.h defines KVM_SET_IRQCHIP as > > #define KVM_SET_IRQCHIP _IOR(KVMIO, 0x63, struct kvm_irqchip) > > But the verb "SET" in the ioctl name would imply that the ioctl > encoding constructor should be _IOW, not _IOR. > > Note also that KVM_SET_PIT seems to have the same encoding issue. > > Yes, there are some bad encodings for the kvm ioctls. Unfortunately Linux doesn't enforce the directions, so it wasn't discovered in time. -- error compiling committee.c: too many arguments to function