* bad? encoding for KVM_SET_IRQCHIP
@ 2009-10-05 22:40 Robert Henry
2009-10-08 12:41 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Robert Henry @ 2009-10-05 22:40 UTC (permalink / raw)
To: kvm
I am concerned about an apparent misencoding for ioctl KVM_SET_IRQCHIP
kvm/include/linux/kvm.h defines KVM_SET_IRQCHIP as
#define KVM_SET_IRQCHIP _IOR(KVMIO, 0x63, struct kvm_irqchip)
But the verb "SET" in the ioctl name would imply that the ioctl
encoding constructor should be _IOW, not _IOR.
Note also that KVM_SET_PIT seems to have the same encoding issue.
Robert Henry
rrh@google.com
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: bad? encoding for KVM_SET_IRQCHIP
2009-10-05 22:40 bad? encoding for KVM_SET_IRQCHIP Robert Henry
@ 2009-10-08 12:41 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2009-10-08 12:41 UTC (permalink / raw)
To: Robert Henry; +Cc: kvm
On 10/06/2009 12:40 AM, Robert Henry wrote:
> I am concerned about an apparent misencoding for ioctl KVM_SET_IRQCHIP
>
> kvm/include/linux/kvm.h defines KVM_SET_IRQCHIP as
>
> #define KVM_SET_IRQCHIP _IOR(KVMIO, 0x63, struct kvm_irqchip)
>
> But the verb "SET" in the ioctl name would imply that the ioctl
> encoding constructor should be _IOW, not _IOR.
>
> Note also that KVM_SET_PIT seems to have the same encoding issue.
>
>
Yes, there are some bad encodings for the kvm ioctls. Unfortunately
Linux doesn't enforce the directions, so it wasn't discovered in time.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-08 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-05 22:40 bad? encoding for KVM_SET_IRQCHIP Robert Henry
2009-10-08 12:41 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).