From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] qemu-kvm: move msi-x to Makefile.target Date: Thu, 08 Oct 2009 15:21:26 +0200 Message-ID: <4ACDE756.7030807@redhat.com> References: <20091006122150.GA9525@redhat.com> <4ACDDE89.7080404@redhat.com> <4ACDE1C6.1020208@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org, gleb@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:10996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758052AbZJHNVz (ORCPT ); Thu, 8 Oct 2009 09:21:55 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n98DLTda027867 for ; Thu, 8 Oct 2009 09:21:29 -0400 In-Reply-To: <4ACDE1C6.1020208@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/08/2009 02:57 PM, Avi Kivity wrote: > On 10/08/2009 02:43 PM, Avi Kivity wrote: >> On 10/06/2009 02:21 PM, Michael S. Tsirkin wrote: >>> KVM interrupt injection support depends on target, >>> so MSI-X needs to be in Makefile.target for interrupt >>> injection to work. We'll be able to clean it up once >>> interrupt injection is upstream. >>> >>> This fixes virtio breakage with kvm caused by 263b7947327e13. >>> >> >> Applied, thanks. >> > > Er, this doesn't build: > > In file included from /home/avi/qemu-kvm/hw/msix.c:18: > /home/avi/qemu-kvm/qemu-kvm.h:1234: error: field =91kvm_sw_breakpoint= s=92=20 > has incomplete type > > Dropped. > And re-applied, after seeing your previous fix. --=20 error compiling committee.c: too many arguments to function