Re: [PATCH] qemu-kvm: kvm headers update

[Avi Kivity <avi@redhat.com>]

On 10/06/2009 07:09 PM, Arnd Bergmann wrote:
> On Tuesday 06 October 2009, Avi Kivity wrote:
>    
>> On 10/05/2009 09:27 PM, Michael S. Tsirkin wrote:
>>      
>>>
>>>        
>>>> Or is this the output of 'make headers_install'?
>>>>
>>>>          
>>> yes. I just added include to kvm_types to add the CONFIG_ stuff.
>>> Or maybe instead we should fix users to depend on the correct ifdefs.
>>>
>>>
>>>        
>> I think 'make headers_install' results in non-portable headers since it
>> unifdefs stuff out.
>>      
> The point of 'make headers_install' is to turn kernel headers into
> user space headers, e.g. removing address space annotations
> that are undefined in user space but required in the kernel.
>
> Unifdef only removes parts under #ifdef __KERNEL__, and by extension,
> anything under CONFIG_*, which is not allowed outside of __KERNEL__,
> because it may have an entirely different meaning in user space.
>
> So, for building qemu, we should really use a copy of the 'installed'
> version, but of course not for building the external module.
>    

Yeah - kvm headers used to depend on CONFIG_*, but looks like this was 
fixed (by me - oh my memory).

-- 
error compiling committee.c: too many arguments to function