From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2 3/9] provide in-kernel ioapic Date: Thu, 08 Oct 2009 15:54:11 +0200 Message-ID: <4ACDEF03.6010406@redhat.com> References: <1254953315-5761-1-git-send-email-glommer@redhat.com> <1254953315-5761-2-git-send-email-glommer@redhat.com> <1254953315-5761-3-git-send-email-glommer@redhat.com> <1254953315-5761-4-git-send-email-glommer@redhat.com> <4ACDEDEC.60706@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , qemu-devel@nongnu.org, kvm-devel To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:21954 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758392AbZJHNyn (ORCPT ); Thu, 8 Oct 2009 09:54:43 -0400 In-Reply-To: <4ACDEDEC.60706@us.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/08/2009 03:49 PM, Anthony Liguori wrote: > Glauber Costa wrote: >> This patch provides kvm with an in-kernel ioapic. We are currently >> not enabling it. >> The code is heavily based on what's in qemu-kvm.git. > > It really ought to be it's own file and own device model. Having the > code mixed in with ioapic.c is confusing because it's unclear what > code is in use when the in-kernel model is used. I disagree. It's the same device with the same guest-visible interface and the same host-visible interface (save/restore, 'info ioapic' if we write one). Splitting it into two files will only result in code duplication. Think of it as an ioapic accelerator. -- error compiling committee.c: too many arguments to function