From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH v2 3/9] provide in-kernel ioapic Date: Thu, 08 Oct 2009 17:53:46 +0200 Message-ID: <4ACE0B0A.9060205@siemens.com> References: <1254953315-5761-1-git-send-email-glommer@redhat.com> <1254953315-5761-2-git-send-email-glommer@redhat.com> <1254953315-5761-3-git-send-email-glommer@redhat.com> <1254953315-5761-4-git-send-email-glommer@redhat.com> <4ACDEDEC.60706@us.ibm.com> <4ACDEF03.6010406@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Anthony Liguori , Glauber Costa , qemu-devel@nongnu.org, kvm-devel To: Avi Kivity Return-path: Received: from thoth.sbs.de ([192.35.17.2]:15446 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbZJHPyr (ORCPT ); Thu, 8 Oct 2009 11:54:47 -0400 In-Reply-To: <4ACDEF03.6010406@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Avi Kivity wrote: > On 10/08/2009 03:49 PM, Anthony Liguori wrote: >> Glauber Costa wrote: >>> This patch provides kvm with an in-kernel ioapic. We are currently >>> not enabling it. >>> The code is heavily based on what's in qemu-kvm.git. >> >> It really ought to be it's own file and own device model. Having the >> code mixed in with ioapic.c is confusing because it's unclear what >> code is in use when the in-kernel model is used. > > I disagree. It's the same device with the same guest-visible interface > and the same host-visible interface (save/restore, 'info ioapic' if we > write one). Splitting it into two files will only result in code > duplication. Shared functions can be pushed into a commonly used module (ioapic-common.c). And everyone touching it should realize then that it could affect more than one user. Jan -- Siemens AG, Corporate Technology, CT SE 2 Corporate Competence Center Embedded Linux