From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/9] KVM: SVM: Add tracepoint for nested vmrun Date: Thu, 08 Oct 2009 17:58:22 +0200 Message-ID: <4ACE0C1E.40506@redhat.com> References: <1254996199-17667-1-git-send-email-joerg.roedel@amd.com> <1254996199-17667-4-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25547 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751033AbZJHP6x (ORCPT ); Thu, 8 Oct 2009 11:58:53 -0400 In-Reply-To: <1254996199-17667-4-git-send-email-joerg.roedel@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/08/2009 12:03 PM, Joerg Roedel wrote: > This patch adds a dedicated kvm tracepoint for a nested > vmrun. > > Signed-off-by: Joerg Roedel > --- > arch/x86/kvm/svm.c | 6 ++++++ > arch/x86/kvm/trace.h | 33 +++++++++++++++++++++++++++++++++ > arch/x86/kvm/x86.c | 1 + > 3 files changed, 40 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c > index 884bffc..907af3f 100644 > --- a/arch/x86/kvm/svm.c > +++ b/arch/x86/kvm/svm.c > @@ -1726,6 +1726,12 @@ static bool nested_svm_vmrun(struct vcpu_svm *svm) > /* nested_vmcb is our indicator if nested SVM is activated */ > svm->nested.vmcb = svm->vmcb->save.rax; > > + trace_kvm_nested_vmrun(svm->vmcb->save.rip - 3, svm->nested.vmcb, > + nested_vmcb->save.rip, > + nested_vmcb->control.int_ctl, > + nested_vmcb->control.event_inj, > + nested_vmcb->control.nested_ctl); > + > It's better to pass only 'svm' as argument and have the tracepoint code derive everything else, since (I think) argument setup is done unconditionally, and only the actual trace_kvm call is patched out. It may not work out due to where the trace code is compiled, but it's worth trying. -- error compiling committee.c: too many arguments to function