From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/9] KVM: SVM: Add tracepoint for invlpga instruction Date: Thu, 08 Oct 2009 18:01:55 +0200 Message-ID: <4ACE0CF3.7090101@redhat.com> References: <1254996199-17667-1-git-send-email-joerg.roedel@amd.com> <1254996199-17667-8-git-send-email-joerg.roedel@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: In-Reply-To: <1254996199-17667-8-git-send-email-joerg.roedel@amd.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 10/08/2009 12:03 PM, Joerg Roedel wrote: > This patch adds a tracepoint for the event that the guest > executed the INVLPGA instruction. > + > + TP_printk("rip=0x%016llx asid=%d adress=0x%016llx\n", > + __entry->rip, __entry->asid, __entry->address) > +); > s/adress/address/. Also, kvm tracepoints don't use '=' in TP_printk(), please keep it consistent. Yeah, I know, but I don't have any real comments to make. -- error compiling committee.c: too many arguments to function