From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/9] KVM: SVM: Add tracepoint for invlpga instruction Date: Thu, 08 Oct 2009 18:21:09 +0200 Message-ID: <4ACE1175.1010706@redhat.com> References: <1254996199-17667-1-git-send-email-joerg.roedel@amd.com> <1254996199-17667-8-git-send-email-joerg.roedel@amd.com> <4ACE0CF3.7090101@redhat.com> <20091008161815.GF14073@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Alexander Graf , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Joerg Roedel Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44140 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758446AbZJHQVk (ORCPT ); Thu, 8 Oct 2009 12:21:40 -0400 In-Reply-To: <20091008161815.GF14073@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/08/2009 06:18 PM, Joerg Roedel wrote: > >> Also, kvm tracepoints don't use '=' in TP_printk(), please keep it >> consistent. >> > I had it with "key: value" formating first but decided to do it this way > because it simplifies automatic parsing of these trace events. With this > format a script can first split by spaces and get the key-value pairs by > splitting on the equal sign. This is also more robust against changes in > the format. > > Automatic parsing should use the binary transport (which simply has the TP_struct things). -- error compiling committee.c: too many arguments to function