From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Qemu-devel] Re: [PATCH 2/3] qemu: make cirrus init value pci spec compliant Date: Sun, 11 Oct 2009 18:37:17 +0200 Message-ID: <4AD209BD.5020300@redhat.com> References: <20091011133626.GA10229@redhat.com> <20091011134559.GN16702@redhat.com> <20091011135240.GA10277@redhat.com> <20091011135748.GO16702@redhat.com> <20091011143535.GA10401@redhat.com> <4AD1EED3.5000901@redhat.com> <20091011144428.GA10429@redhat.com> <4AD1F173.8040401@redhat.com> <20091011161232.GA10132@redhat.com> <4AD206BE.3050904@redhat.com> <20091011163334.GA6248@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , Jamie Lokier , Anthony Liguori , "qemu-devel@nongnu.org" , kvm-devel To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58691 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754115AbZJKQhw (ORCPT ); Sun, 11 Oct 2009 12:37:52 -0400 In-Reply-To: <20091011163334.GA6248@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/11/2009 06:33 PM, Michael S. Tsirkin wrote: > On Sun, Oct 11, 2009 at 06:24:30PM +0200, Avi Kivity wrote: > >> On 10/11/2009 06:12 PM, Michael S. Tsirkin wrote: >> >>> >>>> The guest is running during the upgrade, so the qemu executable is still >>>> from the old install (but deleted). >>>> >>>> >>> Oh, I don't think we should re-read it from file each time. >>> We could read it at startup, keep a copy around for reboots. >>> >>> >> We do that, see hw/loader.c. >> > Which function specifically? > rom_add_file(). -- error compiling committee.c: too many arguments to function