From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm-devel <kvm@vger.kernel.org>
Subject: Single memory slot
Date: Thu, 15 Oct 2009 16:33:11 +0900 [thread overview]
Message-ID: <4AD6D037.3060301@redhat.com> (raw)
One way to improve the gfn_to_pfn() memslot search is to register just
one slot. This can only work on 64-bit, since even the smallest guests
need 4GB of physical address space. Apart from speeding up
gfn_to_page(), it would also speed up mmio which must iterate over all
slots, so a lookup cache cannot help.
This would require quite a bunch of changes:
- modify gfn_to_pfn() to fail gracefully if the page is in the slot but
unmapped (hole handling)
- modify qemu to reserve the guest physical address space
- modify qemu memory allocation to use MAP_FIXED to allocate memory
- some hack for the vga aliases (mmap an fd multiple times?)
- some hack for the vmx-specific pages (e.g. APIC-access page)
Not sure it's worthwhile, but something to keep in mind if a simple
cache or sort by size is insufficient due to mmio.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
next reply other threads:[~2009-10-15 7:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 7:33 Avi Kivity [this message]
2009-10-15 12:46 ` Single memory slot Alexander Graf
2009-10-15 19:49 ` Marcelo Tosatti
2009-10-15 18:51 ` Anthony Liguori
2009-10-15 23:43 ` Avi Kivity
2009-10-15 19:46 ` Marcelo Tosatti
2009-10-15 23:48 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD6D037.3060301@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).