From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL Date: Thu, 15 Oct 2009 17:07:20 +0900 Message-ID: <4AD6D838.2030008@redhat.com> References: <20091013160647.27006.58598.stgit@mchn012c.ww002.siemens.net> <20091013160648.27006.25850.stgit@mchn012c.ww002.siemens.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:65002 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755460AbZJOIHw (ORCPT ); Thu, 15 Oct 2009 04:07:52 -0400 In-Reply-To: <20091013160648.27006.25850.stgit@mchn012c.ww002.siemens.net> Sender: kvm-owner@vger.kernel.org List-ID: On 10/14/2009 01:06 AM, Jan Kiszka wrote: > @@ -1586,6 +1719,7 @@ static long kvm_dev_ioctl_check_extension_generic(long arg) > case KVM_CAP_USER_MEMORY: > case KVM_CAP_DESTROY_MEMORY_REGION_WORKS: > case KVM_CAP_JOIN_MEMORY_REGIONS_WORKS: > + case KVM_CAP_VCPU_STATE: > #ifdef CONFIG_KVM_APIC_ARCHITECTURE > case KVM_CAP_SET_BOOT_CPU_ID: > #endif > This should be done only for the archs that implement the ioctl. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.