From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/4] KVM: x86: Add VCPU substate for NMI states Date: Thu, 15 Oct 2009 18:29:07 +0900 Message-ID: <4AD6EB63.9030306@redhat.com> References: <20091013160647.27006.58598.stgit@mchn012c.ww002.siemens.net> <20091013160648.27006.29041.stgit@mchn012c.ww002.siemens.net> <4AD6D8B6.3050003@redhat.com> <4AD6E9E1.1040704@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , "kvm@vger.kernel.org" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9261 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932075AbZJOJ3i (ORCPT ); Thu, 15 Oct 2009 05:29:38 -0400 In-Reply-To: <4AD6E9E1.1040704@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/15/2009 06:22 PM, Jan Kiszka wrote: >> Needs a KVM_CAP as well. >> > KVM_CAP_VCPU_STATE will imply KVM_CAP_NMI_STATE, so I skipped the latter > (user space code would use the former anyway to avoid yet another #ifdef > layer). > OK. New bits will need the KVM_CAP, though. Perhaps it makes sense to query about individual states, including existing ones? That will allow us to deprecate and then phase out broken states. It's probably not worth it. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.