From: Jan Kiszka <jan.kiszka@siemens.com>
To: Avi Kivity <avi@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH 4/4] KVM: x86: Add VCPU substate for NMI states
Date: Thu, 15 Oct 2009 13:27:09 +0200 [thread overview]
Message-ID: <4AD7070D.7070108@siemens.com> (raw)
In-Reply-To: <4AD6EB63.9030306@redhat.com>
Avi Kivity wrote:
> On 10/15/2009 06:22 PM, Jan Kiszka wrote:
>>> Needs a KVM_CAP as well.
>>>
>> KVM_CAP_VCPU_STATE will imply KVM_CAP_NMI_STATE, so I skipped the latter
>> (user space code would use the former anyway to avoid yet another #ifdef
>> layer).
>>
>
> OK. New bits will need the KVM_CAP, though.
For sure.
>
> Perhaps it makes sense to query about individual states, including
> existing ones? That will allow us to deprecate and then phase out
> broken states. It's probably not worth it.
You may do this already with the given design: Set up a VCPU, then issue
KVM_GET_VCPU_STATE on the substate in question. You will either get an
error code or 0 if the substate is supported. At least no additional
kernel code required.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2009-10-15 11:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 16:06 [PATCH 0/4] Extensible VCPU state IOCTL Jan Kiszka
2009-10-13 16:06 ` [PATCH 1/4] KVM: Reorder IOCTLs in main kvm.h Jan Kiszka
2009-10-13 16:06 ` [PATCH 3/4] KVM: x86: Add support for KVM_GET/SET_VCPU_STATE Jan Kiszka
2009-10-13 16:06 ` [PATCH 4/4] KVM: x86: Add VCPU substate for NMI states Jan Kiszka
2009-10-15 8:09 ` Avi Kivity
2009-10-15 9:22 ` Jan Kiszka
2009-10-15 9:29 ` Avi Kivity
2009-10-15 11:27 ` Jan Kiszka [this message]
2009-10-25 13:11 ` Avi Kivity
2009-10-26 7:40 ` Jan Kiszka
2009-10-13 16:06 ` [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL Jan Kiszka
2009-10-15 8:00 ` Avi Kivity
2009-10-15 9:22 ` Jan Kiszka
2009-10-15 9:33 ` Avi Kivity
2009-10-15 8:07 ` Avi Kivity
2009-10-15 9:22 ` Jan Kiszka
2009-10-15 8:11 ` Avi Kivity
2009-10-15 9:22 ` Jan Kiszka
2009-10-15 14:54 ` Glauber Costa
2009-10-15 15:57 ` Glauber Costa
2009-10-15 16:06 ` Jan Kiszka
2009-10-15 16:23 ` Glauber Costa
2009-10-13 16:18 ` [RFC][PATCH] kvm: x86: Add support for KVM_GET/PUT_VCPU_STATE Jan Kiszka
2009-10-14 8:52 ` [PATCH] qemu-kvm: x86: Add support for NMI states Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD7070D.7070108@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).