Re: [PATCH 2/4] KVM: Add unified KVM_GET/SET_VCPU_STATE IOCTL

[Jan Kiszka <jan.kiszka@siemens.com>]

Glauber Costa wrote:
> On Thu, Oct 15, 2009 at 05:11:27PM +0900, Avi Kivity wrote:
>> On 10/14/2009 01:06 AM, Jan Kiszka wrote:
>>> Add a new IOCTL pair to retrieve or set the VCPU state in one chunk.
>>> More precisely, the IOCTL is able to process a list of substates to be
>>> read or written. This list is easily extensible without breaking the
>>> existing ABI, thus we will no longer have to add new IOCTLs when we
>>> discover a missing VCPU state field or want to support new hardware
>>> features.
>>>
>>> This patch establishes the generic infrastructure for KVM_GET/
>>> SET_VCPU_STATE and adds support for the generic substates REGS, SREGS,
>>> FPU, and MP. To avoid code duplication, the entry point for the
>>> corresponding original IOCTLs are converted to make use of the new
>>> infrastructure internally, too.
>>>
>>>    
>> One last thing - Documentation/kvm/api.txt needs updating.  Glauber,  
>> this holds for your patches as well.
> Now looking at it... you do realize that that file is terribly outdated, right?

At least it's terribly incomplete. I just decided to add my stuff at the
bottom and wait for a bored soul to refactor, fix, extend, whatever this
thing. :)

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux